Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
This preview looks good. At the moment it means all previous meetups have been removed from the "previous events" section, but they can presumably be put back by adding them to the google calendar. I like this proposed way of managing the events going forwards. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Events (including locals) are pulled from the GraphQL Foundation Calendar. The meetups file is just a list of locals, it is NOT a list of their events. This PR removes the duplication by stripping next/prev from locals so the only way to source upcoming/prior locals is via the calendar events. If events are missing on the foundation calendar, let me know.